-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rateLimit option to amqp gateway (#353) #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayak
reviewed
Oct 15, 2019
fayak
reviewed
Oct 15, 2019
fayak
previously approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sweet
fayak
previously approved these changes
Oct 15, 2019
Signed-off-by: Damien Grisonnet <[email protected]>
Signed-off-by: Damien Grisonnet <[email protected]>
Signed-off-by: Damien Grisonnet <[email protected]>
dgrisonnet
force-pushed
the
amqp-consume-limit
branch
from
October 16, 2019 00:03
c966b49
to
22743b7
Compare
VaibhavPage
suggested changes
Oct 16, 2019
Signed-off-by: Damien Grisonnet <[email protected]>
VaibhavPage
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closed
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* Add rateLimit option to amqp gateway (argoproj#353) Signed-off-by: Damien Grisonnet <[email protected]> * Add ratePeriod option to amqp gateway Signed-off-by: Damien Grisonnet <[email protected]> * Fix period value Signed-off-by: Damien Grisonnet <[email protected]> * Fix errors import to keep the codebase consistent Signed-off-by: Damien Grisonnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.